search

eic / drich-dev

Resources for EPIC dRICH Development
3 stars 5 forks source link

fix shared ptr #111

Closed chchatte92 closed 1 year ago

chchatte92 commented 1 year ago

Briefly, what does this PR introduce?

This PR introduces the fixes needed to pixel gap cut test following the new gsl::not_null

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR change default behavior?

      The testing script currently crashes.
chchatte92 commented 1 year ago

This line seems problematic, the print statements after is not getting executed. auto pos_local = geo.GetSensorLocalPosition(cellID, pos_global); https://github.com/eic/drich-dev/blob/a328bf27d1bbd040460a55a61a30b7986b5b7385/src/test_pixel_gap_cuts.cpp#L77

c-dilks commented 1 year ago

Seems to be working now.

chchatte92 commented 1 year ago

LoL. I am not sure how though!!

chchatte92 commented 1 year ago

I found the building works perfectly well. But, when executed I could not generate the png file. On a deeper look inside EICRecon I find that when the method GetLocalPosition is trying to find the VolumeManagerContext of the cellID, it does not work and I have understood that is what actually the crash (execution) talks about:

VolumeManager    ERROR lookupContext: Failed to search Volume context 00040007001D7D78 [Unknown identifier]
terminate` called after throwing an instance of 'std::runtime_error'
  what():  VolumeManager: lookupContext: Failed to search Volume context 00040007001D7D78 [Unknown identifier]
Aborted (core dumped)

So the thing which puzzles me is the cellID we are passing this way, may not be meaningful?

chchatte92 commented 1 year ago

Please ignore my all stupid comments /concerns before.... https://github.com/eic/drich-dev/pull/111#issuecomment-1751682004 It is definitely working!! I was plugging in ana.edm4hep.root (by copying an analysis file as recon file inside out dir), and @c-dilks you know, for very obvious reasons the test did not find any sim hits!!!! With a meaningful input here it is what it produces... image

c-dilks commented 1 year ago

If this is ready for review+merge, please mark it ready.