search

eic / eic-smear

fast simulation tool originally developed by the BNL EIC task force
GNU General Public License v3.0
2 stars 11 forks source link

TreeToHepMC confuses milibarn and microbarn #26

Open kkauder opened 1 year ago

kkauder commented 1 year ago

Environment: (where does this bug occur, have you tried other environments)

All

Steps to reproduce: (give a step by step account of how to trigger the bug)

  1. Convert a EicTree root file to HepMC using TreeToHepMC

Expected Result: (what do you expect when you execute the steps above)

crossSection gets converted from microbarn to HepMC's standard picobarn

Actual Result: (what do you get when you execute the steps above)

TreeToHepMC false assumes that the input crossSection is in milibarn, and is thus wrong by a factor of 1000

Offending code: https://github.com/eic/eic-smear/blob/master/src/erhic/TreeToHepMC.cxx#L130-L153

wdconinc commented 1 year ago

TreeToHepMC confuses milibarn and microbarn

Wouter confuses milibarn and microbarn too ;-)