search

eic / eic-spack

Spack packages for the Electron Ion Collider
3 stars 6 forks source link

Add hepmcmerger #647

Open kkauder opened 3 months ago

kkauder commented 3 months ago

Briefly, what does this PR introduce?

Add a package for https://github.com/eic/HEPMC_Merger

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

kkauder commented 3 months ago

I couldn't test it, can you tell me how? This is something assembed from looking at existing packages but I'm flying blind

wdconinc commented 3 months ago

I couldn't test it, can you tell me how? This is something assembed from looking at existing packages but I'm flying blind

You can do something like:

docker run --rm -it spack/ubuntu-noble:0.21.0
git clone https://github.com/eic/eic-spack
git -C eic-spack checkout <branch>
spack repo add eic-spack
spack install <pkg>

(This could have typos, on my phone.)

kkauder commented 3 months ago

After chewing on this command for three hours, it just failed with the unrelated

 >> 9686    FAILED: tools/clang/lib/ASTMatchers/Dynamic/CMakeFiles/obj.clangDynamicASTMatchers.dir/Re
             gistry.cpp.o
     9687    /opt/spack/lib/spack/env/gcc/g++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_M

Is there anything else I can do?

wdconinc commented 3 months ago

Is there anything else I can do?

Not in this PR, apparently. Can you copy the full error message (with more than 'FAILED') and file it on spack?

wdconinc commented 3 months ago

Is there anything else I can do?

Not in this PR, apparently. Can you copy the full error message (with more than 'FAILED') and file it on spack?

And tag me in the issue on spack.

kkauder commented 3 months ago

I undid the f-string. It didn't work and this syntax is literally the same throughout the repo according to grep -r DCMAKE_CXX_STANDARD

wdconinc commented 3 months ago

Use single quotes inside the f-string arguments.

wdconinc commented 3 months ago

See last two examples in https://peps.python.org/pep-0498/#escape-sequences for correct f-string syntax.

kkauder commented 3 months ago

Thanks for all the help, @wdconinc ! Is the fact that the checks pass good enough to try including it in eic-shell?

wdconinc commented 3 months ago

Not at all. The checks don't do anything ;-)