eic / epic-analysis

General (SI)DIS analysis framework for the EIC
GNU Lesser General Public License v3.0
3 stars 9 forks source link

Full simulation #12

Closed sanghwapark closed 2 years ago

sanghwapark commented 3 years ago

ATHENA full detector simulation analysis chain is added. AnalysisDD4hep is an inherited class from Analysis which was initially developed to analyze Delphes outputs. Most of the histogram bin settings, input and output file name handling, flags (e.g. Reconstruction method) functions are defined in Analysis.

Some To-dos/wishlist:

sanghwapark commented 3 years ago

This doesn't work since the Analysis class is an incomplete type. For now, updated the AnalysisDD4hep to just declare Analysis pointer. Later what we should probably do is to make a base class (say AnalysisBase) for all analysis classes.

Confirmed the new commit 7e1c59f works again for the Delphes output.

c-dilks commented 2 years ago

Closing (for cleaning up old issues); we should eventually go through the Analysis-derived classes carefully anyway