eic / epic-analysis

General (SI)DIS analysis framework for the EIC
GNU Lesser General Public License v3.0
3 stars 9 forks source link

ci: compare Arches and BryceCanyon, with and without radiative corrections #227

Closed c-dilks closed 1 year ago

c-dilks commented 1 year ago

Briefly, what does this PR introduce?

Compare both EPIC configurations, with radiative corrections on vs. off

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

only on CI

c-dilks commented 1 year ago

@rseidl-rcf: this PR adds comparisons between the two EPIC configurations (Arches and BryceCanyon), along with comparisons with radcor and noradcor. Take a look at the artifacts from https://github.com/eic/epic-analysis/actions/runs/3792024332

The comparison.EPIC.* directories compare the two EPIC configs with and without radcor, while the comparison.LEGACY* directories compare EPIC Arches radcor with Pythia6 radcor files passed through Delphes, and the latest ECCE and ATHENA productions.

The resolution plots are still absolute (since #230 is not merged yet)

I'm afraid we have to dramatically reduce the BryceCanyon statistics for regular CI tests, since the corresponding RECO files are enormous and the workflow now takes 2.5 hours. I would like to keep it around our usual 50 minutes. Besides, it's trivial to open a PR whenever we want to run much higher stats (or we can even make such a job trigger only on commits on main, if we want to do that with regularity).