eic / epic-analysis

General (SI)DIS analysis framework for the EIC
GNU Lesser General Public License v3.0
3 stars 9 forks source link

fix: `delete` any `TFile` pointer created by `TFile::Open()` #244

Closed c-dilks closed 1 year ago

c-dilks commented 1 year ago

Briefly, what does this PR introduce?

Any TFile which is opened with TFile::Open() will create a pointer that will not be automatically deleted, does not like to be wrapped by a smart pointer, and may not be fully closed by TFile::Close() when streaming from S3.

Thanks to @rseidl-rcf for finding and fixing this bug!

Hopefully this resolves our exit 13 mystery in #232

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

no