fix: make `pybind` inclusion optional - Githubissues

eic / epic-analysis

General (SI)DIS analysis framework for the EIC

GNU Lesser General Public License v3.0

3 stars 9 forks source link

fix: make `pybind` inclusion optional #251

Closed c-dilks closed 1 year ago

c-dilks commented 1 year ago

Briefly, what does this PR introduce?

Some pybind headers were still included in Kinematics.h; this PR ensures macro SIDIS_MLPRED controls their inclusion.

Fixes runtime error: https://github.com/eic/epic-analysis/actions/runs/4346053472/jobs/7591698317

What kind of change does this PR introduce?

[x] Bug fix (issue #__)
[ ] New feature (issue #__)
[ ] Documentation update
[ ] Other: __

Please check if this PR fulfills the following:

[ ] Tests for the changes have been added
[ ] Documentation has been added / updated
[x] Changes have been communicated to collaborators: @cpecar

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

no

c-dilks commented 1 year ago

@cpecar: CI checks pass now. This PR also removes the libpython3.10 link; on one hand we needed this for pybind, but on the other hand, we should avoid locking ourselves to a specific python library version and it's likely we want to switch to a different python-to-c++ binding anyway (as discussed).