eic / epic

Geometry Description of the ePIC Experiment
https://eic.github.io/epic
GNU Lesser General Public License v3.0
24 stars 43 forks source link

Merge `optical_materials.xml` into `materials.xml` #147

Open wdconinc opened 2 years ago

wdconinc commented 2 years ago

Is your feature request related to a problem? Please describe. There are currently two sets of material definitions, which will lead to overlapping entries (e.g. PbWO4 is moving in that direction with multiple definitions shared between optical and non-optical).

There is no fundamental reasons to have two files, other than (possibly) readability due to optical property matrices (a possible split which does not lead to duplication could therefore be to keep those optical properties in a separate file).

Furthermore, optical_materials.xml contains more than materials, i.e. it contains optical surfaces.

Describe the solution you'd like

Optical surface properties may need to move to dedicated subsystem files where they can be maintained, or need to be made generic. E.g. MirrorSurface_DRICH could be renamed Anomet_Miro_Silver or whatever will be used.

Describe alternatives you've considered Maintain the status quo...

Additional context This could be combined with #47.

wdconinc commented 2 years ago

@c-dilks Mostly affects your materials.

c-dilks commented 2 years ago

Couple of thoughts:

wdconinc commented 2 years ago