eic / epic

DD4hep Geometry Description of the ePIC Experiment
https://eic.github.io/epic
GNU Lesser General Public License v3.0
24 stars 43 forks source link

Implement detector hardware threshold #413

Closed wdconinc closed 1 year ago

wdconinc commented 1 year ago

Is your feature request related to a problem? Please describe. Detector hardware thresholds should be implemented in the geometry definition to ensure they are applied correctly and consistently. This is preferred over implementation at the reconstruction level.

References:

Describe the solution you'd like This should be added to the detectors, ideally close to the geometry definition. That may not be exactly possible, though. Here are a few options:

Describe alternatives you've considered This can (also) be implemented in EICrecon digitization algorithms.

wdconinc commented 1 year ago

https://github.com/wdconinc/DD4hep/commit/510ea9326c3604b94b0aa855c13ec13a228e1ad2

wdconinc commented 1 year ago

https://github.com/eic/npsim/pull/9

wdconinc commented 1 year ago

Merged in https://github.com/eic/npsim/pull/9.