Move sensor material parameters to XML file

RomanTkachenko-dev commented 3 months ago

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

[ ] Bug fix (issue #772)
[ ] New feature (issue #__)
[ ] Documentation update
[ ] Other: __

Please check if this PR fulfills the following:

[ ] Tests for the changes have been added
[ ] Documentation has been added / updated
[ ] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

billlee77 commented 2 months ago

@wdconinc @kkauder @veprbl Hi Wouter, Kolja, and Dimitry, Please take a 2nd look at the pull request, we made appropriate changes to define material differently, could you review and provide further comments? Also, I am not sure why there is still a check that fails, and I am not sure it is related to our changes.

veprbl commented 2 months ago

@billlee77 This is good. Thank you for addressing the comments!

veprbl commented 2 months ago

(the validate-material-map will fail and that's currently expected)

eic / epic