search

eidelen / DicomToMesh

A command line tool to transform a DICOM volume into a 3d surface mesh (obj, stl or ply). Several mesh processing routines can be enabled, such as mesh reduction, smoothing or cleaning. Works on Linux, OSX and Windows.
MIT License
451 stars 93 forks source link

Folder with dicom can't be loaded. #52

Closed Sir0ga90 closed 1 week ago

Sir0ga90 commented 3 months ago

Folder with dicom can't be loaded. Easy fix - dicomRoutines.cpp, line 68 ! need to be added before checkDataLoaded(rawVolumeData)

luzpaz commented 1 month ago

make a PR perhaps ?

Sir0ga90 commented 1 month ago

Permission is denied.

eidelen commented 1 month ago

@Sir0ga90 Everybody is allowed to make a pull request. Check this link: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

luzpaz commented 3 weeks ago

@Sir0ga90 do you still plan to make a PR ?

Sir0ga90 commented 1 week ago

@luzpaz as I have mentioned before access is denied image

luzpaz commented 1 week ago

@Sir0ga90 you're misunderstanding git, I think. You need to set upstream to your fork of this repo; push changes to your fork and then make a PR from your fork against upstream https://github.com/eidelen/DicomToMesh

That is why it's called a Pull Request. The upstream owner get to choose if to add your requested contribution or not.

Sir0ga90 commented 1 week ago

@luzpaz you'r misunderstanding what I have done. Upstream to the repo can't be created because of access rights to your repo.

luzpaz commented 1 week ago

@Sir0ga90 where is your fork of this repo ?
Unless you renamed it, it should be: https://github.com/Sir0ga90/DicomToMesh/

Here's mine:
https://github.com/luzpaz/DicomToMesh/

Sir0ga90 commented 1 week ago

@luzpaz, aha, forking has different workflow in compare with branches approach. Created pull request. Thank you.