Why reverse session_id_context ?

[lxlenovostar]

  void start() override {
      if(set_session_id_context) {
        // Creating session_id_context from address:port but reversed due to small SSL_MAX_SSL_SESSION_ID_LENGTH
        session_id_context = std::to_string(config.port) + ':';
        session_id_context.append(config.address.rbegin(), config.address.rend());
        SSL_CTX_set_session_id_context(context.native_handle(), reinterpret_cast<const unsigned char *>(session_id_context.data()),
                                       std::min<std::size_t>(session_id_context.size(), SSL_MAX_SSL_SESSION_ID_LENGTH));
      }
      ServerBase::start();
    }

Why we need reverse session_id_context? this maybe not change length of string.

Thank you.

[eidheim]

The rationale was to include the most significant parts of address:port in case this exceeded SSL_MAX_SSL_SESSION_ID_LENGTH

[lxlenovostar]

@eidheim Why use rbegin()/rend() instead of begin()/end() ? Thank you.

[eidheim]

Again, the thought was to include the most significant parts of the address. For instance, the country code is more important to keep than www. at start of an address.

[lxlenovostar]

Thank you.