Request minimum needed access rights in Process::kill() on Windows

eidheim / tiny-process-library

A small platform independent library making it simple to create and stop new processes in C++, as well as writing to stdin and reading from stdout and stderr of a new process

MIT License

338 stars 73 forks source link

Request minimum needed access rights in Process::kill() on Windows #14

Closed dschinde closed 8 years ago

dschinde commented 8 years ago

Requesting PROCESS_ALL_ACCESS is excessive. Since you only call TerminateProcess() on the opened HANDLE, you should request PROCESS_TERMINATE.

eidheim commented 8 years ago

Thank you, I'll have a look at these two issues in a couple of days.