Check examples and samples for agent names with underscores _

eidolon-ai / eidolon

The first AI Agent Server, Eidolon is a pluggable Agent SDK and enterprise ready, deployment server for Agentic applications

https://www.eidolonai.com/

Apache License 2.0

297 stars 32 forks source link

Check examples and samples for agent names with underscores _ #702

Open flynntsang opened 2 months ago

flynntsang commented 2 months ago

Following up on #690, a github search shows we still have a number of samples where agents are named underscores _ as separators. Apparently that's a no-no for K8S. Underscores should be changed to hyphens -.

To change:
- resource names in YAML files
- docs and READMEs that refer to resources in YAML files or CLI
Files not to change:
- don't change names of python classes

muddi900 commented 2 months ago

So is 0de3974dc0212b5c0c1872e073e6016611d76094 what you are looking for?

flynntsang commented 2 months ago

@muddi900 Thanks for helping out! I believe it's just the name of the agents that's the problem.

The resource (YAML) file names do not need to change, nor any python code. Just the agent metadata in the resource YAML files, e.g.:

apiVersion: eidolon/v1
kind: Agent
metadata:
  name: hello_world # this needs to change to hello-world

I think we got most of the hello_world agents, but there are a number of other examples that we haven't checked yet.

Thanks again!