search

eidosmontreal / unreal-vdb

This repo is a non-official Unreal plugin that can read OpenVDB and NanoVDB files in Unreal.
Apache License 2.0
686 stars 108 forks source link

Description of current translucency issues and small fixes #49

Closed Andrej730 closed 1 year ago

Andrej730 commented 1 year ago

I think it's important to get all information about current issues in one place so people won't spend time testing it themselves as did I.

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

thilamb commented 1 year ago

Thanks for the contribution. I agree that transparency issues should be mentioned somewhere. Is it okay if I only take part of your changes and re-write the helpme paragraph to my taste ?

You also need to sign the CLA if you want your contribution to be added. Just leave a comment saying: I have read the CLA Document and I hereby sign the CLA

Andrej730 commented 1 year ago

Thanks for the contribution. I agree that transparency issues should be mentioned somewhere. Is it okay if I only take part of your changes and re-write the helpme paragraph to my taste ?

Sure.

I have read the CLA Document and I hereby sign the CLA.

thilamb commented 1 year ago

I've added some of your suggestions and rewrote some others in the main branch. Thanks a lot for your involvement.