Closed sankar-palanivel closed 1 year ago
Good improvement, will not be able to test myself, maybe good with a reviewer with more insight than me when deleting things :)
PR has been tested on a remote Kubernetes cluster successfully.
cmd = ./easy2use remove -t Kubernetes -d <_domain_> -n <_namespace_> -e </path/to/bundles> start Eiffel -y
After executing the cmd, the PVC data-eiffel-rabbitmq-oss-eiffel-0 was still there (not deleted).
After executing the cmd, the PVC data-eiffel-rabbitmq-oss-eiffel-0 wasn't there (deleted). The following is a part of the cmd's response:
release "eiffel-mongodb-oss-eiffel" uninstalled
persistentvolumeclaim "eiffel-mongodb-oss-eiffel" deleted
.
.
.
release "eiffel-rabbitmq-oss-eiffel" uninstalled
persistentvolumeclaim "data-eiffel-rabbitmq-oss-eiffel-0" deleted
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.8", GitCommit:"4a3b558c52eb6995b3c5c1db5e54111bd0645a64", GitTreeState:"clean", BuildDate:"2021-12-15T14:52:11Z", GoVersion:"go1.16.12", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.17", GitCommit:"a7736eaf34d823d7652415337ac0ad06db9167fc", GitTreeState:"clean", BuildDate:"2022-12-08T11:42:04Z", GoVersion:"go1.16.15", Compiler:"gc", Platform:"linux/amd64"}
Applicable Issues
Fixes #59
Description of the Change
Alternate Designs
The rabbitmq service deployment model can be changed from statefulset to Deployment kind, if needed
Benefits
This will be a proper cleanup of easy2use sandbox by removing all of its pv/pvc resources.
Possible Drawbacks
N/A
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.
Signed-off-by: Sankar Palanivel sankar.palanivel@est.tech