eiffel-community / eiffel-gerrit-herald

Service for emitting Eiffel messages over RabbitMQ, triggered by Gerrit events.
Apache License 2.0
3 stars 2 forks source link

Logging setup needs an overhaul #6

Open magnusbaeck opened 4 years ago

magnusbaeck commented 4 years ago

Description

SLF4J is used for the logging, which is good. However, we're not declaring a dependency to that library but relying on it to arrive transitively. We're also not including a concrete logging library so the only reason we're getting logs at all is that eiffel-remrem-semantics includes logback (which I think is a bug in that library; see comment thread in https://github.com/eiffel-community/eiffel-remrem-semantics/pull/69). This means that the inclusion of log4j.properties is misleading since that file is never used.

I think we should:

Motivation

Logging is important and we should make it easy for people who deploy the service to change the logging configuration. Adding missing dependencies is good house keeping.