eiffel-community / eiffel-gerrit-plugin

Eiffel Gerrit plugin listens on the changes in Gerrit and sends out Eiffel events
Apache License 2.0
3 stars 15 forks source link

Use plugin config #46

Closed m-linner-ericsson closed 4 years ago

m-linner-ericsson commented 4 years ago

Applicable Issues

Description of the Change

In many places, the plugin dir and/or the project name was passed around. The change introduced in this pull requests changes this behavior and passes the plugin configuration instead

Alternate Designs

Leave it, but the code would be harder to read.

Benefits

Less passing of variables

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Signed-off-by: Mattias Linnér, mattias.linner@ericsson.com