search

eiffel-community / eiffel-intelligence

Eiffel Intelligence is a real time data aggregation and analysis solution for Eiffel events.
Apache License 2.0
11 stars 72 forks source link

Fixed NullPointerException when mongoDB connection goes down #430

Closed Umadevi-Kapu closed 4 years ago

Umadevi-Kapu commented 4 years ago

Applicable Issues

Fix: https://github.com/eiffel-community/eiffel-intelligence/issues/387

Description of the Change

Previously when EI looses connection with mongoDB we will get nullpointer exceptions in several places in the code. So Handled the NullPointerException by giving proper error log messages and also in some places handled errors by throwing MongoClientException instead of returning null.

Alternate Designs

Benefits

Whenever MongoDB goes down, will get error message instead of NullPointerException.

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Signed-off-by:

Christoffer-Cortes commented 4 years ago

Could you please not force push? Avoid using commit --amend and just make a new commit for every change you make and push that to your review branch. That way you get a history of changes. Force pushing erases the commit history and there is no way to follow the changes. There is no easy way to find a previous test run you've done as well unless you do some digging in travis.

Umadevi-Kapu commented 4 years ago

ok