eiffel-community / eiffel-intelligence

Eiffel Intelligence is a real time data aggregation and analysis solution for Eiffel events.
Apache License 2.0
11 stars 72 forks source link

Remove duplicate logging #466

Closed e-pettersson-ericsson closed 4 years ago

e-pettersson-ericsson commented 4 years ago

Applicable Issues

I noticed some duplicate logging happening when updating or deleting subscriptions in Eiffel Intelligence.

Description of the Change

Add missing javadoc on some methods in SubscriptionService Remove duplicate logging when updating and deleting subscriptions Remove unneccessary if statement and unused imports

Alternate Designs

Benefits

More readable code

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Signed-off-by: Emelie Pettersson emelie.pettersson@ericsson.com