search

eiffel-community / eiffel-intelligence

Eiffel Intelligence is a real time data aggregation and analysis solution for Eiffel events.
Apache License 2.0
11 stars 72 forks source link

remove old bindings of a queue from message bus #471

Closed durga-vasaadi closed 4 years ago

durga-vasaadi commented 4 years ago

Applicable Issues

Description of the Change

If binding key is changed in configuration, the old bindingkey is removed from mb queue.

Alternate Designs

Benefits

Reduction in conflicts between the binding keys. <

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Signed-off-by: Durga vasaadi durga.vasaadi@tcs.com

tobiasake commented 4 years ago

Were we not supposed to implement this in Eiffel-Commons library, so Event-Repository also can benefit and use this implementation?

Navyatha-reddi commented 4 years ago

I'm happy, all previous comments I had are now resolved. It seems Travis never triggered on the last commit, I don't know why? Thankyou Emelie, i will consider this as sign off on review comments. i will check with travis build.

Navyatha-reddi commented 4 years ago

Were we not supposed to implement this in Eiffel-Commons library, so Event-Repository also can benefit and use this implementation?

Hi, As of now we didn't have any information to implement this in Event repository and In future if there is any such information we will intiate necessary discussions. As of now changes are working fine in EI and we dnt see any issues

tobiasake commented 4 years ago

Were we not supposed to implement this in Eiffel-Commons library, so Event-Repository also can benefit and use this implementation?

Hi, As of now we didn't have any information to implement this in Event repository and In future if there is any such information we will intiate necessary discussions. As of now changes are working fine in EI and we dnt see any issues

As I wrote in chat with you about a meeting that I was forced into, it was said that EI 2.x will have the code directly implemented due to the urgent requirement, and master branch will have the implementation in a library, e.g. Eiffel-Commons. There is no hurry to get this into master branch, so this can be implemented in a library and master branch use the library. And then Event-Repository can also use this library.

Navyatha-reddi commented 4 years ago

Were we not supposed to implement this in Eiffel-Commons library, so Event-Repository also can benefit and use this implementation?

Hi, As of now we didn't have any information to implement this in Event repository and In future if there is any such information we will intiate necessary discussions. As of now changes are working fine in EI and we dnt see any issues

As I wrote in chat with you about a meeting that I was forced into, it was said that EI 2.x will have the code directly implemented due to the urgent requirement, and master branch will have the implementation in a library, e.g. Eiffel-Commons. There is no hurry to get this into master branch, so this can be implemented in a library and master branch use the library. And then Event-Repository can also use this library.

Hi Tobias, As mentioned in chat with you.. I cross checked with team and it seems like they didn't have any communcation to implement this in library.... As of now we are trying to merge these changes in Master.. Would that be fine?

Navyatha-reddi commented 4 years ago

You should consider moving out this code to a library. Looks ok.

Thankyou Tobias, we will consider that.