eiffel-community / eiffel-remrem-generate

Apache License 2.0
8 stars 70 forks source link

RemremGenerateController doesn't log exceptions in catch-all traps #140

Closed magnusbaeck closed 5 years ago

magnusbaeck commented 5 years ago

Description

The handlers in RemremGenerateController each have catch (Exception e) { ... } blocks that translate unanticipated exceptions into 500 errors. That's fine, but nothing is logged so even those with access to the service logs can debug what's going wrong.

Motivation

Ideally we should never hit the catch-all exception handlers, but if we do it's important to save sufficient details about the error to make it possible for operators of the service to be able to debug the problem.