magnusbaeck
commented
4 years ago I think this correction is made in the wrong place. The correct place would be in generateMsg() where the NPE originates. Reasons:
- We can't blindly assume that any NPE resulting from the call to generateMsg() is caused by a value missing from the input.
- Only in generateMsg() can we produce an error message that includes information about what value is missing.
- eiffel-semantics has other clients that would benefit from a correction there.
- A bad message type value is caught by generateMsg() so it's reasonable that it checks other input values too.
Divya-Kuppula
Handled NullPointerException for Null cases.
Applicable Issues
Description of the Change
Alternate Designs
Benefits
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.
Signed-off-by: