search

eiffel-community / eiffel-remrem-generate

Apache License 2.0
8 stars 70 forks source link

Added lenientValidation support to REMReM generate #170

Closed raja-maragani closed 4 years ago

raja-maragani commented 4 years ago

Applicable Issues

https://github.com/eiffel-community/eiffel-remrem-generate/issues/171

Description of the Change

Added Lenient Validation support to REMReM Generate, The Lenient Validation will perform the only mandatory field validation and non-mandatory validation failures will place in Eiffel message as a new property(remremGenerateFailures)

Alternate Designs

Benefits

The REMReM generate validation will not fail on non-fetal Eiffel message field issues. This feature is an option to the user, the user can decide the enable/disable the Lenient Validation. By default it is disabled.

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Signed-off-by: @raja-maragani

magnusbaeck commented 4 years ago

This PR depends on https://github.com/eiffel-community/eiffel-remrem-semantics/pull/128 where I just posted some comments. I'll hold off the review until that PR progresses.

raja-maragani commented 4 years ago

even though we declare the default values in the API, it is always prefered to be sent by the users. Can we add that part in documentation.

Also the CLI is non-backwards compatible if the lv is not provided. so should that be also handled ?

CLI works as backward compatibility. API default values from the user is a separate part issue https://github.com/eiffel-community/eiffel-remrem-generate/issues/161

raja-maragani commented 4 years ago

If no other comments, I will merge the PR.