Implement compatibility layer for eiffel graphql api

t-persson commented 4 years ago

Description

Right now REMReM can only communicate with the ericsson event repository. It would be nice if one could choose which event repository to communicate with.

I'm not sure if any other REMReM component communicates with event repositories. If so, then maybe this should be added to a common library instead.

This issue is filed here as a hopeful "fix" for this issue: eiffel-community/eiffel-graphql-api#7

Motivation

Would be easier for anyone using the eiffel graphql api to use REMReM. Would make REMReM more configurable.

Exemplification

REMReM seems like a great service and wants to be the central point to generating and publishing events within the eiffel community. Having it compatible with all eiffel communtiy event repositories would be a great boon.

Benefits

Possibly a wider usage of REMReM

Possible Drawbacks

Another part to maintain and verify. Might also include even more parts if more event repositories arrive.

magnusbaeck commented 4 years ago

I guess it depends on whether we want there to be a standardized event query API (like the one provided by Ericsson's ER and currently supported by eiffel-remrem-generate). If so it would be up to the ER implementations to provide such an API as an option. I suspect eiffel-remrem-generate isn't the only tool that would benefit from event lookups so a standard query API sounds reasonable to me.

Regardless of where we choose to implement this particular API adapter we should formalize and document the existing event query API.

m-linner-ericsson commented 3 years ago

@t-persson @magnusbaeck Does https://github.com/eiffel-community/eiffel-remrem-generate/pull/179 help you in any way?

t-persson commented 3 years ago

Added comment in PR as well as on slack :)

magnusbaeck commented 3 years ago

This was discussed some weeks ago and we agreed that a subset of Ericsson's ER API (see PR referenced above) will be considered a standard lookup API for ERs, in which case there's no need to adapt REMReM Generate to the GraphQL API. So i guess this issue should be closed?

m-linner-ericsson commented 3 years ago

@t-persson Based on @magnusbaeck comment: Is it ok to close this issue?

t-persson commented 3 years ago

@m-linner-ericsson Yes! https://github.com/eiffel-community/eiffel-goer

eiffel-community / eiffel-remrem-generate