search

eiffel-community / eiffel-remrem-generate

Apache License 2.0
8 stars 70 forks source link

Updated pom structure and artifactId so GAV format is followed #183

Closed tobiasake closed 3 years ago

tobiasake commented 3 years ago

Applicable Issues

Follow common GAV format that all Eiffel components follow.

Description of the Change

Today eiffel-remrem-generate application is released with war artifact ArtifactID "generate-service" which do not follow GAV format where the Eiffel application name should be the used as artifactId, as other Eiffel components is following.

This change the artifactId to use the "eiffel-remrem-generate" application name instead of "generate-service" name.

This change makes also so that JitPack stores with correct artifact name and version and path.

Alternate Designs

Benefits

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Signed-off-by:

raja-maragani commented 3 years ago

@tobiasake this change will impact the our internal CI/CD flows, we need to add a new internal task to handle this, @SantoshNC68 please create new task.

tobiasake commented 3 years ago

@tobiasake this change will impact the our internal CI/CD flows, we need to add a new internal task to handle this, @SantoshNC68 please create new task.

Ok, we can skip this GAV/purl change , but check the Ericsson internal CIC ticket about this and other internal tasks in CIC ticket for handling RemRem CI/CD internally at Ericsson.

m-linner-ericsson commented 3 years ago

@tobiasake Is it ok for you if we close this?

tobiasake commented 3 years ago

Ok, I close this PR.