search

eiffel-community / eiffel-remrem-generate

Apache License 2.0
8 stars 70 forks source link

Fix overriding semantics messaging version in newer openjdk 8 versions #206

Closed tobiasake closed 1 year ago

tobiasake commented 1 year ago

Applicable Issues

In later java 8 version class is loaded in reversed order and if external eiffel-semantic version jar files are provided then internal built-in eiffel-semantic version is used. External eiffel-semantic version is configured with java flag: java -Djava.ext.dirs=/path/to/eiffel-semantic-jar-files-dir/ -jar /path/to/generate-service-x.y.z.war

-Djava.ext.dirs is deprecated in Java 8 since many years ago and the -classpath should be used in newer Java versions, example: java -classpath "/path/to/eiffel-semantic-protocol-jars/*:publish-service/target/publish-service-2.0.26.war" org.springframework.boot.loader.WarLaunch

Description of the Change

Change so external provided eiffel-semantic version is used if provided with "-Djava.ext.dirs".

Alternate Designs

Benefits

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Signed-off-by:

tobiasake commented 1 year ago

@RajuBeemreddy1 @z-sztrom Same change is done in RemRem-Publish, please review my PR in RemRem-Publish as well: https://github.com/eiffel-community/eiffel-remrem-publish/pull/252

tobiasake commented 1 year ago

Added documentation about how to run RemRem-Generate and how to override Eiffel-Protocol version. Please check and review. @RajuBeemreddy1 @z-sztrom

If docs are Ok, I will add same docs to the RemRem-Publish patch.