search

eiffel-community / eiffel-remrem-generate

Apache License 2.0
8 stars 70 forks source link

Degraded the spring-boot-maven-plugin to 2.7.5 #208

Closed piyush-sadangi closed 1 year ago

piyush-sadangi commented 1 year ago

Applicable Issues

Description of the Change

Degraded the spring-boot-maven-plugin to 2.7.5 as 3.0.0 is not compatible with jdk 8

Alternate Designs

Benefits

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Signed-off-by: piyush.sadangi@tcs.com -->

m-linner-ericsson commented 1 year ago

@piyush-sadangi Out of curiosity. Why did you degrade the version?

jainadc9 commented 1 year ago

Hi Mattias, Issue is the latest version of the plugin 3.0.0 was being pulled from maven-central and is not compatible with jdk 8 . It was expecting minimum java version 17 , to make it compatible with jdk8 it had to be downgraded to 2.7.5. We faced issue in jitpack ci/cd pipeline so we had to downgrade . Similar issue can be found here : https://stackoverflow.com/questions/71002476/spring-boot-with-spring-version-2-5-7-fails-repackage-with-jdk-1-8

m-linner-ericsson commented 1 year ago

It would be good to put that information in the PR. Please update this one with the reason. In the future include the reason for changes in the PR text. This is so that other people looking at the PR knows why you did the PR.

I know the template is a bit cumbersome but please state the reasons behind the PR.