eiffel-community / eiffel-remrem-semantics

eiffel-remrem-semantics
https://eiffel-community.github.io/eiffel-remrem-semantics/
Other
4 stars 55 forks source link

Need more information from Event class as this doesn't have information about data and links #79

Closed SantoshNC68 closed 3 years ago

SantoshNC68 commented 6 years ago

Need data and Links information in the Event class that can be used to fetch information about the events.

rogpers-ericsson commented 6 years ago

This would make sense. What would the returned types be though?

ghost commented 6 years ago

I think we are asking a common-sense thing, data should return the abstract form so we can at least access properties that are common to all. I will contact OPO to escalate it.

vasile-baluta commented 6 years ago

In my opinion returning a Json object from the event and access the information with the path as a key is more general and applicable to all Json based messages.

SantoshNC68 commented 6 years ago

Yes, but we are asking for Event containing information about data and links. As all events extends Event class this will help us in fetching the data and links information irrespective of what event we use. If we use the remrem-semantics library this will help us a lot to have the data and links information available

vasile-baluta commented 6 years ago

Sure. Lets see who has time to contribute with this.

raja-maragani commented 6 years ago

The below properties are suitable properties to access from Event Class.

Meta:

Data:

Links:

Created a pull request Please have a look. https://github.com/Ericsson/eiffel-remrem-semantics/pull/92

SantoshNC68 commented 3 years ago

Closing the issue as there are no more inputs on this.