search

eiffel-community / eiffel

The Eiffel framework vocabulary, descriptions, guides and schemas along with links to relevant implementation repositories.
Apache License 2.0
121 stars 59 forks source link

Json keyword misspelled in all ActC yaml files #376

Closed e-backmark-ericsson closed 7 months ago

e-backmark-ericsson commented 8 months ago

Description

All versions of yaml files for EiffelActivityCanceledEvent has a misspelling on 'additonalProperties'. It should be 'additionalProperties'. See for example https://github.com/eiffel-community/eiffel/blob/master/definitions/EiffelActivityCanceledEvent/1.0.0.yml#L47 This results in wrongly generated Json schemas for ActC, see for example: https://github.com/eiffel-community/eiffel/blob/master/schemas/EiffelActivityCanceledEvent/1.0.0.json#L155

Motivation

We need to have syntactically correct json schemas

Exemplification

.

Benefits

We need to have syntactically correct json schemas

Possible Drawbacks

What to do with old versions of this event?

magnusbaeck commented 8 months ago

Is this something that happened in the conversion of the schemas to the YAML format or has the problem been around forever?

e-backmark-ericsson commented 8 months ago

It was introduced in January 2017 through #86