eiffel-community / eiffelevents-sdk-go

A Go SDK for working with Eiffel events
Apache License 2.0
1 stars 2 forks source link

signature: Make AuthorIdentity implement {Marshal,Unmarshal}Text #92

Closed magnusbaeck closed 4 months ago

magnusbaeck commented 4 months ago

Applicable Issues

9

Description of the Change

This makes it easier to e.g. put AuthorIdentity values in configuration and API structs and have the values properly marshaled to/from string.

Since the type has grown we extracted it to a file of its own to keep the clutter in verifier.go down.

Alternate Designs

We could've implemented MarshalJSON and UnmarshalJSON instead, but MarshalText and UnmarshalText apply more broadly.

Possible Drawbacks

None.

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Signed-off-by: Magnus Bäck \magnus.back@axis.com