search

eiffelhub / json

Eiffel JSON library
Other
18 stars 13 forks source link

missing make_from_separate #19

Open phgachoud opened 4 years ago

phgachoud commented 4 years ago

Don't know the politic of this lib about changing some things and if worth it making a pull request about that but, I would have needed a make_from_separate feature. As I already made a pull request and did never have any answer about it I don't want to spend more time trying to contribute to it if it doesn't worth it.

What option should I take 1) implement it and do a pull request 2) what I'm doing actually which is inheriting from it and define that function

jocelyn commented 4 years ago

Indeed we haven't noticed your previous pull request. (note we merged your previous PR today... very long delay).

So please, fill a Pull request for this make_from_separate topic, and we'll review and hopefully merge it.

If you don't get comment on GitHub within 48 hours, please contact me directly as you recently did.

phgachoud commented 4 years ago

Starting on my fork on branch readme_scoop_functionalities on https://github.com/phgachoud/json/blob/readme_scoop_functionalities/library/kernel/json_array.e The idea is to provide a make_from_separate as the topic of this issue. What do you think about the topic and best practices. The point is that the make_from_separate (other: separate like Current) has to call a fill procedure, this one has to create non separate objects from existing separate objects which are descendants of JSON_VALUE, and all of them. I don't see any other way then what I implemented which I already shared into the google groups which is creating (depending on a type check) non separate JSON_OBJECT, JSON_STRING, etc and then extend the current container. Do you see any much more generic option for that?

I'll commit my proposition as soon as I get it.

Thx in advance