search

eiffelhub / json

Eiffel JSON library
Other
18 stars 13 forks source link

Tests - Update syntax and improve implementation #8

Closed Conaclos closed 10 years ago

Conaclos commented 10 years ago

Update syntax, style, documentation and contracts for the testing suite.

Replace Assigment attempt with object test. USe across loops instead of traditional loops. Use a better implementation for converters.

jocelyn commented 10 years ago

LGTM (Looks Good To Me) Javier can you double check and merge if you agree?

jocelyn commented 10 years ago

I agree but this will be for another pull request. reviewing a pull request with many indentation changes is not pleasant. So first let's check this one, and then we can either use the "Prettify" command of EiffelStudio, or any other tool. But we should have a global commit only for those indentation issues.

On Tue, Jul 1, 2014 at 10:08 AM, Victorien ELVINGER < notifications@github.com> wrote:

Note : I noted a mix between space and tabulations on each files and sometimes on the same line. This mix was already existing before my commits.

Git reports the mix when it is on the same line. Then, for each new line introduced, I decided to use tabs. Since tabs and space have the same length on Eiffel Studio, the printing is ok, however on Github the length is not the same...

Maybe it could be better to choose between space or tabs and then to make a global and evil update...

— Reply to this email directly or view it on GitHub https://github.com/eiffelhub/json/pull/8#issuecomment-47628362.

jvelilla commented 10 years ago

LGMT, I will merge it,