eifinger / hass-weenect

Homeassistant integration for weenect
MIT License
6 stars 2 forks source link

feat: allow disabling gps #363

Closed andreasbrett closed 4 months ago

andreasbrett commented 4 months ago

https://github.com/eifinger/hass-weenect/pull/283 contains multiple changes and is stale for more than half a year now because of missing tests. Disabling the GPS is a quick win though and could easily be merged. I created a dedicated PR for that mere feature so it can be included.

I'll try to implement the remaining features in further dedicated PRs (and will incl. the required tests).

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.20%. Comparing base (7745671) to head (1a08c8a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #363 +/- ## ======================================= Coverage 98.20% 98.20% ======================================= Files 20 20 Lines 668 668 ======================================= Hits 656 656 Misses 12 12 ``` | [Flag](https://app.codecov.io/gh/eifinger/hass-weenect/pull/363/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kevin+Eifinger) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/eifinger/hass-weenect/pull/363/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kevin+Eifinger) | `98.20% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kevin+Eifinger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andreasbrett commented 4 months ago

Sure, it's implemented now