search

eigan / yr-php-library

Small php library for the norwegian weather service Yr.
18 stars 4 forks source link

Fixed: cache life to sec converter #4

Closed JanPetterMG closed 8 years ago

JanPetterMG commented 8 years ago

Default cache life of 10 sec has to be wrong, and I found the original code not working like expected.

Line 99:

// Convert cache life to seconds
$cache_life * 60;
JanPetterMG commented 8 years ago

What's wrong with the StyleCI check?

I fix 4 lines of code according to GitHub. The StyleCI check says 20 changed files with 310 additions and 293 deletions, it's ridiculous!

This has absolutely nothing to do with my pull request, to fix it, click on the Create fix in the StyleCI report. You'll find it here: https://styleci.io/analyses/86e9Mz

eigan commented 8 years ago

Default cache life of 10 sec has to be wrong, and I found the original code not working like expected.

wow, how did I miss this.. Thanks!