search

eigengo / monitor

Library for monitoring the Typesafe stack-based applications.
Apache License 2.0
127 stars 24 forks source link

Change pointcut definition for actorOf #76

Closed MarioArias closed 11 years ago

MarioArias commented 11 years ago

The actual pointcut definition don't catch actor creation using the Akka Java API.

This pr change the pointcut definition to catch every implementation of ActorRefFactory Trait

Fix issue #78

hughsimpson commented 11 years ago

:+1:

hughsimpson commented 11 years ago

Awesome generalisation. We should also update the comments in ActorCellMonitoringAspect.aj on the pointcut advice for actorOf and namedActorOf

janm399 commented 11 years ago

:+1:

hughsimpson commented 11 years ago

:+1:

janm399 commented 11 years ago

On line 220 of the ActorCellMonitoringAspect, the JavaDoc is malformed. Also, the : on line 216 does not follow the placement in the rest of the file.

Every detail counts, do not allow the code to get messy.

janm399 commented 11 years ago

This is looking good now.