eigenhombre / i3d3

D3-based plotting and histogramming library
25 stars 5 forks source link

Fix duplicate ids #7

Closed mfrere closed 10 years ago

mfrere commented 10 years ago

This prevents having multiple elements having the same ids between plots. However, I'm not really sure if this prevents duplicate ids within the same plot.

This fixes the width issue we saw in firefox. The reason we saw it was obvious in firefox is that firefox is pretty strict regarding w3 standards (ie: forbidden to have multiple elements with the same id in an html document). Since Chrome is very loose in that regard (which is bad imo), it did not react the same way.

mfrere commented 10 years ago

Just tested this in the prototype, and it seems it also fixes the clipping issue for plots, bars, etc...

That's good news but I spent so much time trying to find workarounds before finding/fixing this problem that I'm kinda pissed now.

eigenhombre commented 10 years ago

Sorry you’re pissed! I’m glad you figured out the issue. Thanks again.

On Nov 15, 2013, at 5:03 PM, mfrere notifications@github.com wrote:

Just tested this in the prototype, and it seems it also fixes the clipping issue for plots, bars, etc...

That's good news but I spent so much time trying to find workarounds before finding/fixing this problem that I'm kinda pissed now.

— Reply to this email directly or view it on GitHub.