Geodesic distance is out-of-data with `v0.4` parameterization

eigenvivek / DiffDRR

Auto-differentiable digitally reconstructed radiographs in PyTorch

https://vivekg.dev/DiffDRR

MIT License

148 stars 21 forks source link

Geodesic distance is out-of-data with `v0.4` parameterization #309

Closed eigenvivek closed 4 months ago

eigenvivek commented 4 months ago

The current implementation computes the distance between the last column of the transformation matrix, which represents the quantity Rt. Modify such that distance is only between translations t.

https://github.com/eigenvivek/DiffDRR/blob/528d2ea8af664eeb75322f528106f1bf266e65b3/diffdrr/metrics.py#L146-L153