eigerco / nebula

A soroban contract library
https://nebula.eiger.co
Apache License 2.0
7 stars 2 forks source link

Add more validations in voting contract init methods #67

Closed eloylp closed 1 year ago

eloylp commented 1 year ago

Describe the bug

Some validations are not present in init function of the voting contract. Parameters like voting_period_secs, target_approval_rate_bps and total_voters should never be zero.

mariopil commented 1 year ago

Completed with https://github.com/eigerco/nebula/pull/92