search

eigerco / polka-storage

The Polka Storage Parachain Project
https://eigerco.github.io/polka-storage-book
Apache License 2.0
2 stars 0 forks source link

Don't use padding in add_piece? #436

Open th7nder opened 1 month ago

th7nder commented 1 month ago 
          The alternative [`write_and_preprocess`](https://github.com/filecoin-project/rust-fil-proofs/blob/266acc39a3ebd6f3d28c6ee335d78e2b7cea06bc/filecoin-proofs/src/api/mod.rs#L502) just calls `add_pieces` and forces it to not add a padding, so the whole responsibility falls on the sealing logic and the pipeline. I'd say I'm fine for now with this padding and losing a bit of space, to reduce the complexity of other logic.

_Originally posted by @th7nder in https://github.com/eigerco/polka-storage/pull/434#discussion_r1791918698_

jmg-duarte commented 3 weeks ago

Moving to after P3, currently this works so there's no point in changing right now