search

eight04 / webext-launch-web-auth-flow

Polyfill `launchWebAuthFlow` with popups
MIT License
5 stars 3 forks source link

Add better error messages when manifest.json permissions are missing #6

Closed lucasrmendonca closed 2 years ago

lucasrmendonca commented 2 years ago

Now, console errors such as No "webNavigation" permission declared in manifest.json are thrown when manifest.json file is lacking the necessary permissions

eight04 commented 2 years ago

What is the current error message? I think it should be clear enough without this runtime check.

lucasrmendonca commented 2 years ago

The current message is could not find OnRequest in undefined or something along these lines. Took me a while to understand that I missed a permission.

Hey maybe we don't need this runtime check if we include a sample manifest.json example in the readme.me ?

lucasrmendonca commented 2 years ago

Closing in favor of manifest.json example