search

eighteen73 / orbit

Opinionated overrides for default WordPress behaviour.
MIT License
3 stars 1 forks source link

Remove Carbon Fields #5

Closed edjeavons closed 1 year ago

edjeavons commented 1 year ago

Ideally this plugin would not have a dependency like Carbon Fields. We need to ensure that removing it doesn't spoil usability though.

brettsmason commented 1 year ago

@edjeavons I've pushed up some code to the develop branch. Would you mind taking a look when you get a chance? Ideally in the future we could do with writing a small drop in class for handling duplication across all our plugins, but for now this should remove the dependency.

edjeavons commented 1 year ago

I've taken a look (and made a few amends) and it looks good to me.

We will need to consider the few sites that have already used it before merging into main because some setting names have changes and there's a chance they were utilising Orbit's Carbon Fields elsewhere in the project. It's so few sites that I we can manually update their settings when the new Orbit version is applied.

edjeavons commented 1 year ago

All good now apart from the logo upload. Once that's done we'll merge into main.