eigilnikolajsen / commit-mono

Commit Mono is an anonymous and neutral programming typeface.
https://commitmono.com/
1.14k stars 15 forks source link

Visual Studio not rendering >= and <= properly #24

Closed BradKnowles closed 8 months ago

BradKnowles commented 11 months ago

>= and <= are rendering strangely in Visual Studio 2022 on Windows. The font has been customized with both ligatures and arrows. Visual Studio Code seems to display correctly.

The code sample

var y = travelTime.Month >= 11 || travelTime.Month <= 12;
var x = 1 <= 3;

Visual Studio 2022 image

VS Code image

eigilnikolajsen commented 11 months ago

That's odd. I'll have a look into why this might be. The weirdest thing to me is the fact that the var x = 1 <= 3 renders correctly.

eigilnikolajsen commented 10 months ago

Hello, can I have you try this on the latest version? I just released a new version 1.133 where I flipped those features, so hopefully it should work optimally now.

BradKnowles commented 10 months ago

I’ve been out of town the last few days, I’ll give it a try this week and report back. Thank you!

BradKnowles commented 10 months ago

I'm using 1.134 and am experiencing some oddities in spacing now.

Alts is using all download features and Alt a, Alt G, Alt 6 and 9, and Lifted *

Alts2 is just using all download features and no alternate characters.

Download weight, letter spacing, and line height are all defaults, 450, 0%, and 1.

image

eigilnikolajsen commented 10 months ago

Sorry for the inconveniency, a bug slipped out. The weird vertical metrics have been fixed, so if you don't mind, it'd love for you to try again, to see if the ligatures work now.

BradKnowles commented 10 months ago

Thanks, the vertical issues have been fixed, but unfortunately I still see the same thing in Visual Studio. It works if numbers are on both sides of the <= but as soon as any letters appear, it switches to the full arrow.

I even tried messing with Visual Studio's rendering settings (documented https://learn.microsoft.com/en-us/visualstudio/ide/reference/options-text-editor-advanced?view=vs-2022#text-formatting-method) but no change.

eigilnikolajsen commented 10 months ago

That is very odd. I will see what I can do. Thank you for testing!

BradKnowles commented 9 months ago

I re-tested with 1.138 still seeing the same results. Here is my custom-settings.json so you know what options I've used.

{
  "weight": 400,
  "italic": false,
  "alternates": {
    "cv01": true,
    "cv02": true,
    "cv03": false,
    "cv04": true,
    "cv05": true,
    "cv06": false,
    "cv07": false,
    "cv08": false,
    "cv09": false
  },
  "features": {
    "ss01": true,
    "ss02": true,
    "ss03": true,
    "ss04": true,
    "ss05": true
  },
  "letterSpacing": 0,
  "lineHeight": 1
}
BradKnowles commented 9 months ago

@eigilnikolajsen 1.139 seems to have resolved this issue. Doing more testing across different machines and configurations, but so far so good.

eigilnikolajsen commented 9 months ago

Great to hear, thank you for testing!

BradKnowles commented 8 months ago

Closing issue. 1.139 has been working great in Visual Studio with no further issues.

eigilnikolajsen commented 8 months ago

Great, thank you.