Closed BradKnowles closed 8 months ago
That's odd. I'll have a look into why this might be. The weirdest thing to me is the fact that the var x = 1 <= 3
renders correctly.
Hello, can I have you try this on the latest version? I just released a new version 1.133 where I flipped those features, so hopefully it should work optimally now.
I’ve been out of town the last few days, I’ll give it a try this week and report back. Thank you!
I'm using 1.134 and am experiencing some oddities in spacing now.
Alts is using all download features and Alt a, Alt G, Alt 6 and 9, and Lifted *
Alts2 is just using all download features and no alternate characters.
Download weight, letter spacing, and line height are all defaults, 450, 0%, and 1.
Sorry for the inconveniency, a bug slipped out. The weird vertical metrics have been fixed, so if you don't mind, it'd love for you to try again, to see if the ligatures work now.
Thanks, the vertical issues have been fixed, but unfortunately I still see the same thing in Visual Studio. It works if numbers are on both sides of the <= but as soon as any letters appear, it switches to the full arrow.
I even tried messing with Visual Studio's rendering settings (documented https://learn.microsoft.com/en-us/visualstudio/ide/reference/options-text-editor-advanced?view=vs-2022#text-formatting-method) but no change.
That is very odd. I will see what I can do. Thank you for testing!
I re-tested with 1.138 still seeing the same results. Here is my custom-settings.json
so you know what options I've used.
{
"weight": 400,
"italic": false,
"alternates": {
"cv01": true,
"cv02": true,
"cv03": false,
"cv04": true,
"cv05": true,
"cv06": false,
"cv07": false,
"cv08": false,
"cv09": false
},
"features": {
"ss01": true,
"ss02": true,
"ss03": true,
"ss04": true,
"ss05": true
},
"letterSpacing": 0,
"lineHeight": 1
}
@eigilnikolajsen 1.139 seems to have resolved this issue. Doing more testing across different machines and configurations, but so far so good.
Great to hear, thank you for testing!
Closing issue. 1.139 has been working great in Visual Studio with no further issues.
Great, thank you.
>=
and<=
are rendering strangely in Visual Studio 2022 on Windows. The font has been customized with both ligatures and arrows. Visual Studio Code seems to display correctly.The code sample
Visual Studio 2022![image](https://github.com/eigilnikolajsen/commit-mono/assets/1277856/4440568b-c41e-493f-9ae5-0906c83d1d13)
VS Code![image](https://github.com/eigilnikolajsen/commit-mono/assets/1277856/814d48fb-9dec-4752-a9f4-cee32cbcf3f9)