eigilnikolajsen / commit-mono

Commit Mono is an anonymous and neutral programming typeface.
https://commitmono.com/
1.28k stars 21 forks source link

Latest version messed up line height/vertical positioning? #30

Closed rben01 closed 1 year ago

rben01 commented 1 year ago

In the latest version, line height seems to be totally messed up.

macOS Terminal.app

Line height = 1:

image

Line height = 1.5 looks fine, but is the max line height that Terminal.app can do.

VSCode editor

Line height = 1

image

Line height = 1.5:

image

VSCode terminal

Line height = 1:

image

Line height = 2:

image
eigilnikolajsen commented 1 year ago

This is very curious, thank you for discovering. I have trouble replicating the results, it looks fine in my apps. I suppose you downloaded the fonts from the customize section, do you mind sharing the settings (and if you have any other settings that might have something to say)? It would also be helpful to have a look at the font files, if you can share them here. Thank you.

rben01 commented 1 year ago

These were downloaded directly from the “Download custom for design” link (using Brave Browser, in case that makes s difference). Here are the files: CommitMono.zip

One more datapoint: macOS font book install dialog.

Old version of font:

C1B93C06-6E25-4680-94D0-9C9564726496

New version of font:

FDF75E4A-15C0-450F-B851-9DF8F08E31B0
eigilnikolajsen commented 1 year ago

Thank you, I'll have a look at it and fix it as soon as possible!

fayekydee commented 1 year ago

Hello,

I can confirm a line spacing issue. In my case the overlap between lines is even more severe - see screenshot of konsole in Debian linux. I have downloaded commit mono today from the commitmono.com customize section. I did not change the default line height value ('1'), I only included ligatures and arrows.

commit_line_spacing

eigilnikolajsen commented 1 year ago

It is fixed now. I accidently set the default line height to 0 and not 1, which resulted in really weird vertical metrics. Everything should be normal now.

Steve-OH commented 10 months ago

On a related note, the default line height spacing is very tight. Here's what Commit Mono, Fira Code (fairly typical), and MonoLisa (looser than average) look like in Sublime Text on Win10: image

This is with the 1.134 update.