eigilnikolajsen / commit-mono

Commit Mono is an anonymous and neutral programming typeface.
https://commitmono.com/
1.14k stars 15 forks source link

Ligatures for == not working, but -> are working? #32

Closed pkazmier closed 8 months ago

pkazmier commented 10 months ago

I customized my download to enable ligatures for the set of equal signs as well as for the arrows, but only arrows are actually working. I've tested this in multiple terminals (WezTerm, Kitty) and it's the same. I downloaded the version from the website this morning. Font book tells me it's version 1.134.

image

I've even tried to manually enable them by setting the the stylistic sets explicitly thinking maybe they just were baked in, but that also did not work. I then tried to download the font without the equal ligatures from the website thinking maybe the toggle was reversed by accident—nope, didn't work.

I've used lots of fonts with ligatures in the past and know how to enable settings such as call and ssNN features, so I don't believe this is user error, but I've exhausted my knowledge of how to troubleshoot this further.

eigilnikolajsen commented 10 months ago

Thank you very much for your extensive testing. It most likely is an error in the font, and not on your side. I will have a look to see how I can fix it.

shurizzle commented 10 months ago
immagine

I this can be useful: this is neovim in wezterm. Looks like those symbol's ligatures works only closely surrounded by string delimiters.

eigilnikolajsen commented 10 months ago

Very useful, thank you. I'm actually inclined to believe that neovim doesn't use the space character. Let me explain. The feature is built to only substitute symbols when surrounded by spaces. But the space isn't the only character, I've defined a group of 'space actors' which the quotes you show are part of. The part that surprises me is that space does not work, but these do. Thank you for your test, I will see what I can do.

shurizzle commented 10 months ago
immagine

I don't think it's a vim-only issue, the same thing happens in the terminal

nerdyinu commented 9 months ago

it's not a vim issue. its reproduced in vscode also.

shurizzle commented 8 months ago

image I guess this issue can be marked as solved, right?

eigilnikolajsen commented 8 months ago

Yes, it can, thank you!