search

eigilnikolajsen / commit-mono

Commit Mono is an anonymous and neutral programming typeface.
https://commitmono.com/
1.13k stars 15 forks source link

Commit Mono Not Working In Visual Studio Code #70

Closed dajeed closed 7 months ago

dajeed commented 7 months ago

Font is not being detected by Visual Studio Code. What I mean by that is that whenever I change the font to Commit Mono, the font does not change. Steps I took:

  1. Installed the latest default font under releases.
  2. Restarted Visual Studio Code.
  3. Restarted my computer.
  4. Uninstalled and reinstalled font and tried both OTF and TTF formats.
  5. Issue remains unresolved.

https://github.com/eigilnikolajsen/commit-mono/assets/8452880/fcd9e70a-5e8f-4973-970a-6527975ecfd3

eigilnikolajsen commented 7 months ago

Try one of the following, to see if it resolves the problem:

  1. Add quotes to the font name like 'CommitMono'
  2. Add these lines to the user settings JSON 
    "editor.fontFamily": "CommitMono",
"editor.fontLigatures": true,

Tell me if that works. Or else there might be some other issue causing this.

dajeed commented 7 months ago

I did as you said and it didn't work, but weirdly enough I did manage to fix it by downloading version 1.139. Versions 1.140 and 1.141 don't seem to work on VS Code. On a side note, I'm running Windows 11 Pro 23H2.

eigilnikolajsen commented 7 months ago

Many thanks. I will fix this first priority. I might need some help testing when done.

dajeed commented 7 months ago

I'll be able to test it out for you unless you want to create a testing branch for testing purposes. Let me know 😄

plttn commented 7 months ago

I can replicate this on my Windows machine as well.

It looks like an issue with the font family metadata? If I open Control Panel and navigate to fonts, only one of the 4 versions shows up, rather than showing as a font family.

image

If I delete the 700 bold italic showing here, 700 bold appears to replace it, and repeating until I've deleted all 4 files.

eigilnikolajsen commented 7 months ago

I have located the source of the issue and fixed it. If you download the font from the website it should be fixed. I will update the release on Monday, can't right now.

plttn commented 7 months ago

Looks like that mostly worked.

The family is now working as expected in VSCode, however the only two faces in the family as shown are now 400-regular and 700-italic so I would suspect that any regular italic or unitalicized bold would not show up properly:

image

eigilnikolajsen commented 7 months ago

Honestly I don't know about Windows and fonts at this point. I get only the italics in the folder, but when I go to font settings in settings all 4 show up. Even though only the italics are showing up in my folder, the regular and bold still works in VS code. I've checked the naming multiple times but all seems to be identical between the 4 styles. If you have any tips, throw them my way, please.

Additionally, @vagreargnatry from #68 gets only italic and bold in his folder, so it seems like a gamble what styles show up haha.

image image

plttn commented 7 months ago

Ah yep, my bad, looks like it is actually showing in font settings.

eigilnikolajsen commented 7 months ago

I am closing this since it is resolved with release v1.142.