search

eikeluedeling / decisionSupport

6 stars 3 forks source link

Fix plot dist ef 23.06.23 #40

Closed EduardoFernandezC closed 1 year ago

EduardoFernandezC commented 1 year ago

Hey guys! In this branch, I offer a way to address Jan-Bernd's issue ( #39 ). See my explanation there. I also encountered some weird issues with a package called class when using devtools::check(). I had to add it to the Imports of the description file, as well as, to use import in one of the functions to remove one check note. Let me know if you think I made a mistake.

EduardoFernandezC commented 1 year ago

Hey guys! In the last commit (annexed to this PR), I added a proposal to fix Christine's issue... Now, the arguments cashflow_var_name and facet_labels are matched in the ggplot call via the levels argument. I have read that you are re-shaping/re-writing the package, so this may only be useful in the meanwhile.

eikeluedeling commented 1 year ago

all good here I think