search

eikofee / eikonomiya

a genshin tool to inspect character equipment and compute stuff
MIT License
1 stars 1 forks source link

Assets and game data should be moved into the `data` folder for easier update and a lighter docker image #27

Open eikofee opened 3 months ago

eikofee commented 3 months ago

Title says almost all. For easier updates, gamedata (.yml files) and assets (images and stuff) should be stored into the data folder. Since almost all assets come from Genshin Optimizer, we could make a script that update this data with a git clone -> rename/reorganize assets -> clean up. For game data, it'll be a bit more tricky to potentially convert Genshin Optimizer data from .ts to .yml and add custom strings to cards but it's doable. This data will be stored into the eikonomiya-data repo that could be also cloned to update.

All of this can be scripted in a python file or something and the user can run it manually or maybe with an input from the web interface.

eikofee commented 3 months ago

For the records : All strings regarding talents, weapons, artifacts and stuff are in the locale assets of GO : https://github.com/frzyc/genshin-optimizer/tree/master/libs/gi/dm-localization/assets/locales/en For gamedata values, multiplier and everything, it's in the stats/data folder of GO : https://github.com/frzyc/genshin-optimizer/tree/master/libs/gi/stats/Data

eikofee commented 2 months ago

So now assets and locales are loaded into data. Only missing thing is now the talent values which will get dealt with when adding dmg computations.