search

eikofee / nene-quest

Reproduction of Nene Sakura's game "Nene quest" from the japanese anime "New Game!!" with SFML
MIT License
79 stars 5 forks source link

Meson build system #5

Closed MisterDA closed 6 years ago

MisterDA commented 7 years ago

Hi guys,

Ping @KostiaChardonnet @engboris.

I have integrated in 145e4dc your game with the Meson build system, a relatively new build system notabily used by Gnome, Xorg and Mesa. The perks comparing to your current settings are as follow: you have no build system. So why wouldn't you give Meson a try ? It can be compared to CMake, but the syntax and use are cleaner and simpler.

Meson is fully portable in Linux and Windows. You just need Python, and eventually Ninja.

pip3 install --user meson
sudo apt-get install ninja-build

I have added more instructions in the README file.

Meson can also be used to generate a VSCode project (no CodeBlocks sadly) and it's easier to create an app or a package for your game.

Because of fb0e74f, Meson will generate on-the-fly a file headers/config.hpp containing a path where to load the assets, allowing the possibility for the executable to load the assets at a location determined at compile-time. You can supply your own config file, and Meson will not overwrite it. For example, it'll look like this on a Linux system:

/*
 * Autogenerated by the Meson build system.
 * Do not edit, your changes will be lost.
 */

#pragma once

#define PACKAGE_DATADIR "/usr/share/nene-quest"

Meson also enforces the use of C++11.

The two remaining commits fix errors reported by -fpermissive. I'm more concerned by 44db3d1, was the map supposed to be passed by reference or by value ?

Happy hacking !

eikofee commented 7 years ago

Hey, thanks for your input.

As you may have noticed, our code is pretty messy right now, and we are currently trying to make a stable and maintainable structure for an easier development, as we are close to complete all of the essential gameplay elements (I think). We think it'll wise to finish that refactoring before adding more stuff in the project.

I used CMake a bit in the past, and I must admit I had lot of difficulties to use it properly, you said Meson was easier, I'm glad to hear that, and will look into it later, but can I ask what does it do ? I used CMake for way larger project structures, and it was "only" a tool to generate Makefiles, and giving more headache to me than saving time... 😓

Again, thanks for your contribution.

EDIT : Kostia said to me that this post sounds like a deny. It's not, it's just we need some time before adding stuff to the project.