search

eikonomega / django-notification-system

Want to send notifications from your Django app? Start here.
MIT License
14 stars 9 forks source link

Problems with newer versions of exponent_server_sdk (>=1.0.0) #30

Open nklsw opened 3 years ago

nklsw commented 3 years ago

I recently noticed an error on a fresh installation of my django application: cannot import name 'PushResponseError' from 'exponent_server_sdk' (/app/.heroku/python/lib/python3.8/site-packages/exponent_server_sdk/__init__.py)

After a little research I found out that the exponent_server_sdk package has undergone some changes regarding the PushResponse class. I am not really familiar with this SDK and Expo but as far as I can see, the class got renamed to PushTicket in 1.0.2 and returns a message ID since 1.0.0. In my case I got exponent_server_sdk 2.0.0 installed and am now facing an ImportError because django-notification-system still uses the old class name.

Due to the changes in setup.py, this leads to an error when version 1.0.0 or newer of exponent_server_sdk gets installed.

nklsw commented 3 years ago

I create two PR's for a quickfix (#31) and for a more sustainable fix (#32)

At least the quickfix should be merged as a temporary bugfix.